Debug: fix showing option name for list (vs. list content)
authorJeremy Harris <jgh146exb@wizmail.org>
Wed, 8 May 2024 10:31:52 +0000 (11:31 +0100)
committerJeremy Harris <jgh146exb@wizmail.org>
Thu, 9 May 2024 10:40:57 +0000 (11:40 +0100)
commit1d2868b2d90c230dd4ae42e6f3c7e4958ed75de5
treec5c39f01b6ff4e0852eb6d3758fd5b6e9c75efd6
parent954e7967ad54af3b638d608873833e1fb5b6ea90
Debug: fix showing option name for list (vs. list content)

It's done in a hacky way (always was) and is fragile.
Turns out, too fragile to be good.
- some lists, we cannot match up to an option name
  eg. stderr/0002
- some, we're falling back to comparing the list content; this gets duplicates
  and thus gives incorrect info, which is worse than no info
  (we could scan for dups, I guess?)
  Why do we get dups when we're comparing the addrs of the string?
  - mmm, do we Really get dups?
    - Yes: same option across two routers. Must be a static init for a default.
      In which case, does it being a dup matter?
      - OK, we can check router_name / transport_name

Resulting testsuite sterr changes only partial, here.

There's a double check on local_parts in routers (always was).  Why?

One buildfarm animal (groundhog) is missing a "list element" line
possibly associated with dnssec_request_domains.  Why?
158 files changed:
src/src/deliver.c
src/src/functions.h
src/src/macros.h
src/src/match.c
src/src/readconf.c
src/src/smtp_out.c
src/src/transports/smtp.c
test/log/0630
test/paniclog/0630
test/runtest
test/stderr/0002
test/stderr/0003
test/stderr/0004
test/stderr/0020
test/stderr/0021
test/stderr/0022
test/stderr/0023
test/stderr/0037
test/stderr/0041
test/stderr/0042
test/stderr/0043
test/stderr/0044
test/stderr/0056
test/stderr/0057
test/stderr/0058
test/stderr/0059
test/stderr/0060
test/stderr/0061
test/stderr/0062
test/stderr/0063
test/stderr/0064
test/stderr/0065
test/stderr/0066
test/stderr/0067
test/stderr/0069
test/stderr/0070
test/stderr/0077
test/stderr/0078
test/stderr/0085
test/stderr/0087
test/stderr/0089
test/stderr/0091
test/stderr/0092
test/stderr/0094
test/stderr/0121
test/stderr/0124
test/stderr/0130
test/stderr/0138
test/stderr/0139
test/stderr/0143
test/stderr/0145
test/stderr/0149
test/stderr/0157
test/stderr/0161
test/stderr/0175
test/stderr/0183
test/stderr/0217
test/stderr/0218
test/stderr/0227
test/stderr/0234
test/stderr/0243
test/stderr/0249
test/stderr/0251
test/stderr/0264
test/stderr/0275
test/stderr/0276
test/stderr/0278
test/stderr/0279
test/stderr/0283
test/stderr/0294
test/stderr/0303
test/stderr/0305
test/stderr/0306
test/stderr/0308
test/stderr/0315
test/stderr/0325
test/stderr/0332
test/stderr/0333
test/stderr/0342
test/stderr/0357
test/stderr/0358
test/stderr/0360
test/stderr/0361
test/stderr/0362
test/stderr/0364
test/stderr/0368
test/stderr/0374
test/stderr/0375
test/stderr/0376
test/stderr/0377
test/stderr/0378
test/stderr/0379
test/stderr/0380
test/stderr/0381
test/stderr/0382
test/stderr/0388
test/stderr/0398
test/stderr/0402
test/stderr/0403
test/stderr/0404
test/stderr/0408
test/stderr/0414
test/stderr/0419
test/stderr/0426
test/stderr/0432
test/stderr/0443
test/stderr/0450
test/stderr/0462
test/stderr/0463
test/stderr/0464
test/stderr/0467
test/stderr/0469
test/stderr/0473
test/stderr/0475
test/stderr/0476
test/stderr/0483
test/stderr/0499
test/stderr/0512
test/stderr/0513
test/stderr/0525
test/stderr/0543
test/stderr/0544
test/stderr/0545
test/stderr/0554
test/stderr/0563
test/stderr/0578
test/stderr/0584
test/stderr/0588
test/stderr/0609
test/stderr/0623
test/stderr/0630
test/stderr/0632
test/stderr/0909
test/stderr/1000
test/stderr/1006
test/stderr/1150
test/stderr/1157
test/stderr/1160
test/stderr/2135
test/stderr/2201
test/stderr/2202
test/stderr/2600
test/stderr/2610
test/stderr/2620
test/stderr/3208
test/stderr/3210
test/stderr/3211
test/stderr/3400
test/stderr/3404
test/stderr/3408
test/stderr/3500
test/stderr/4052
test/stderr/4510
test/stderr/4530
test/stderr/5204
test/stderr/5403
test/stderr/5410
test/stderr/5840