fix address generation weirdness

diff --git a/trunk/bf-alerts.pl b/trunk/bf-alerts.pl
index c118cc4e29ff4739fb4fba1c3216d9576e942723..1b9dd1a3b611a879a708c4ef969997f2f5c25afe 100755 (executable)
--- a/trunk/bf-alerts.pl
+++ b/trunk/bf-alerts.pl
@@ -12,6 +12,7 @@ use Safe;
 
 use vars qw($dbhost $dbname $dbuser $dbpass $dbport
        $all_stat $fail_stat $change_stat $green_stat
+       $default_host
 );
 
 require "$ENV{BFConfDir}/BuildFarmWeb.pl";
@@ -193,8 +194,11 @@ my $addr_sth = $db->prepare(q[
 
 
 my $me = `id -un`; chomp $me;
+my $host = `hostname`; chomp ($host);
+$host = $default_host unless ($host =~ m/[.]/ || !defined($default_host));
 
-my $host = `hostname`; chomp $host;
+my $from_addr = "PG Build Farm <$me\@$host>";
+$from_addr =~ tr /\r\n//d;
 
 
 
@@ -216,7 +220,7 @@ foreach my $clearme (@need_cleared)
     }
     my $msg = new Mail::Send;
 
-    $msg->set('From',"PG Build Farm <$me\@$host>");
+    $msg->set('From',$from_addr);
 
     $addr_sth->execute($animal);
 
@@ -244,7 +248,7 @@ foreach my $clearme (@need_alerts)
        "on $sysbranch->{branch} for $hours hours.";
     my $msg = new Mail::Send;
 
-    $msg->set('From',"PG Build Farm <$me\@$host>");
+    $msg->set('From',$from_addr);
 
     $addr_sth->execute($animal);
 

diff --git a/trunk/cgi-bin/pgstatus.pl b/trunk/cgi-bin/pgstatus.pl
index f951aee02ad2afc21fd5467658132e25d6df1cdd..da6c0692d06027c378ee4bef902ccc853c869f2c 100755 (executable)
--- a/trunk/cgi-bin/pgstatus.pl
+++ b/trunk/cgi-bin/pgstatus.pl
@@ -6,6 +6,7 @@ use vars qw($dbhost $dbname $dbuser $dbpass $dbport
        $all_stat $fail_stat $change_stat $green_stat
        $server_time
           $min_script_version $min_web_script_version
+       $default_host
 );
 
 # force this before we do anything - even load modules
@@ -433,17 +434,22 @@ my $stat_type = $stage eq 'OK' ? 'Status' : 'Failed at Stage';
 my $mailto = [@$all_stat];
 push(@$mailto,@$fail_stat) if $stage ne 'OK';
 
-my $me = `id -un`; chomp $me;
+my $me = `id -un`; chomp($me);
 
-my $host = `hostname`; chomp $host;
+my $host = `hostname`; chomp ($host);
+$host = $default_host unless ($host =~ m/[.]/ || !defined($default_host));
+
+my $from_addr = "PG Build Farm <$me\@$host>";
+$from_addr =~ tr /\r\n//d;
 
 my $msg = new Mail::Send;
 
-$msg->set('From',"PG Build Farm <$me\@$host>");
 
 $msg->to(@$mailto);
 $msg->bcc(@$bcc_stat) if (@$bcc_stat);
 $msg->subject("PGBuildfarm member $animal Branch $branch $stat_type $stage");
+$msg->set('From',$from_addr);
+{ my $handle; open($handle,">>/tmp/mailobj"); print $handle scalar(localtime),Dumper($msg); close($handle); }
 my $fh = $msg->open;
 print $fh <<EOMAIL; 
 
@@ -472,7 +478,6 @@ push(@$mailto,@$green_stat) if ($stage eq 'OK' || $prev_stat eq 'OK');
 
 $msg = new Mail::Send;
 
-$msg->set('From',"PG Build Farm <$me\@$host>");
 
 $msg->to(@$mailto);
 $msg->bcc(@$bcc_chg) if (@$bcc_chg);
@@ -483,6 +488,8 @@ $stat_type = "New member: $stage" if $prev_stat eq 'NEW';
 $stat_type .= " failure" if $stage ne 'OK';
 
 $msg->subject("PGBuildfarm member $animal Branch $branch Status $stat_type");
+$msg->set('From',$from_addr);
+{ my $handle; open($handle,">>/tmp/mailobj"); print $handle scalar(localtime),Dumper($msg); close($handle); }
 $fh = $msg->open;
 print $fh <<EOMAIL;
 

diff --git a/trunk/cgi-bin/register.pl b/trunk/cgi-bin/register.pl
index b15a0e24cf88862c4699a604aff695217f641617..37290f8808e13b4fb70f184830b11d67d23483b0 100755 (executable)
--- a/trunk/cgi-bin/register.pl
+++ b/trunk/cgi-bin/register.pl
@@ -7,7 +7,7 @@ use CGI;
 use Template;
 use Captcha::reCAPTCHA;
 
-use vars qw($dbhost $dbname $dbuser $dbpass $dbport $notifyapp $captcha_pubkey $captcha_privkey $template_dir);
+use vars qw($dbhost $dbname $dbuser $dbpass $dbport $notifyapp $captcha_pubkey $captcha_privkey $template_dir $default_host);
 
 require "$ENV{BFConfDir}/BuildFarmWeb.pl";
 
@@ -123,11 +123,14 @@ use Mail::Send;
 
 my $msg = new Mail::Send;
 
-my $me = `id -un`;
+my $me = `id -un`; chomp($me);
+my $host = `hostname`; chomp ($host);
+$host = $default_host unless ($host =~ m/[.]/ || !defined($default_host));
 
-my $host = `hostname`;
+my $from_addr = "PG Build Farm <$me\@$host>";
+$from_addr =~ tr /\r\n//d;
 
-$msg->set('From',"PG Build Farm <$me\@$host>");
+$msg->set('From',$from_addr);
 
 $msg->to(@$notifyapp);
 $msg->subject('New Buildfarm Application');